Add updating devices to apiv1.
We needed a way to be able to update devices after they were created. This is
supported in the devices package, we just needed to expose it using apiv1
endpoints.
In doing so, it became apparent that allowing users to change the Owner of their
Devices wasn't properly thought through, and pending a reason to use it, I'm
just removing it. The biggest issue came when trying to return usable error
messages; we couldn't distinguish between "you don't own the device you're
trying to update" and "you're not allowed to change the owner of the device". I
also couldn't figure out _who should be able to_ change the owner of the device,
which is generally an indication that I'm building a feature before I have a use
case for it.
To support this change, the apiv1.DeviceChange type needed its Owner property
removed.
I also needed to add deviceFromAPI and devicesFromAPI helpers to return
devices.Device types from apiv1.Device types.
There's now a new validateDeviceUpdate helper that checks to ensure that a
device update request is valid and the user has the appropriate permissions.
The createRequest type now accepts a slice of Devices, not a slice of
DeviceChanges, because we want to pass the Owner in.
A new updateRequest type is created, which accepts a DeviceChange to apply.
A new handleUpdateDevice handler is created, which is assigned to the endpoint
for PATCH requests against a device ID. It checks that the user is logged in,
the Device they're trying to update exists, and that it's a valid update. If all
of that is true, the device is updated and the updated device is returned.
Finally, we had to add two new scopes to support new functionality:
ScopeUpdateOtherUserDevices allows a user to update other user's devices, and
ScopeUpdateLastSeen allows a user to update the LastSeen property of a device.
Pending some better error messages, this should be a full implementation of
updating a device, which leaves only the deletion endpoint to deal with.
1 // Copyright 2014 Google Inc. All rights reserved.
2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file.
13 // A Time represents a time as the number of 100's of nanoseconds since 15 Oct
18 lillian = 2299160 // Julian day of 15 Oct 1582
19 unix = 2440587 // Julian day of 1 Jan 1970
20 epoch = unix - lillian // Days between epochs
21 g1582 = epoch * 86400 // seconds between epochs
22 g1582ns100 = g1582 * 10000000 // 100s of a nanoseconds between epochs
27 lasttime uint64 // last time we returned
28 clock_seq uint16 // clock sequence for this run
30 timeNow = time.Now // for testing
33 // UnixTime converts t the number of seconds and nanoseconds using the Unix
34 // epoch of 1 Jan 1970.
35 func (t Time) UnixTime() (sec, nsec int64) {
36 sec = int64(t - g1582ns100)
37 nsec = (sec % 10000000) * 100
42 // GetTime returns the current Time (100s of nanoseconds since 15 Oct 1582) and
43 // clock sequence as well as adjusting the clock sequence as needed. An error
44 // is returned if the current time cannot be determined.
45 func GetTime() (Time, uint16, error) {
51 func getTime() (Time, uint16, error) {
54 // If we don't have a clock sequence already, set one.
58 now := uint64(t.UnixNano()/100) + g1582ns100
60 // If time has gone backwards with this clock sequence then we
61 // increment the clock sequence
63 clock_seq = ((clock_seq + 1) & 0x3fff) | 0x8000
66 return Time(now), clock_seq, nil
69 // ClockSequence returns the current clock sequence, generating one if not
70 // already set. The clock sequence is only used for Version 1 UUIDs.
72 // The uuid package does not use global static storage for the clock sequence or
73 // the last time a UUID was generated. Unless SetClockSequence a new random
74 // clock sequence is generated the first time a clock sequence is requested by
75 // ClockSequence, GetTime, or NewUUID. (section 4.2.1.1) sequence is generated
77 func ClockSequence() int {
80 return clockSequence()
83 func clockSequence() int {
87 return int(clock_seq & 0x3fff)
90 // SetClockSeq sets the clock sequence to the lower 14 bits of seq. Setting to
91 // -1 causes a new sequence to be generated.
92 func SetClockSequence(seq int) {
98 func setClockSequence(seq int) {
101 randomBits(b[:]) // clock sequence
102 seq = int(b[0])<<8 | int(b[1])
105 clock_seq = uint16(seq&0x3fff) | 0x8000 // Set our variant
106 if old_seq != clock_seq {
111 // Time returns the time in 100s of nanoseconds since 15 Oct 1582 encoded in
112 // uuid. It returns false if uuid is not valid. The time is only well defined
113 // for version 1 and 2 UUIDs.
114 func (uuid UUID) Time() (Time, bool) {
118 time := int64(binary.BigEndian.Uint32(uuid[0:4]))
119 time |= int64(binary.BigEndian.Uint16(uuid[4:6])) << 32
120 time |= int64(binary.BigEndian.Uint16(uuid[6:8])&0xfff) << 48
121 return Time(time), true
124 // ClockSequence returns the clock sequence encoded in uuid. It returns false
125 // if uuid is not valid. The clock sequence is only well defined for version 1
127 func (uuid UUID) ClockSequence() (int, bool) {
131 return int(binary.BigEndian.Uint16(uuid[8:10])) & 0x3fff, true