ducky/devices
ducky/devices/context.go
Add more interface tests. Add a test to ensure that, when retrieving Devices, no error is returned if a Device cannot be found. Add a test to ensure that, when adding Devices, adding a Device that shares an ID with a Device already in the Storer returns an ErrDeviceAlreadyExists error. This involved creating the ErrDeviceAlreadyExists error, and modifying the in-memory implementation to properly return it. Fix a go vet issue in our previous test, wherein we forgot to pass the storer to a log message, resulting in a mismatch between the number of variables expected and the number of variables provided. Rename our tests to be better reflective of what they actually test.
1 package devices
3 import (
4 "errors"
6 "golang.org/x/net/context"
7 )
9 const (
10 storerKey = "code.secondbit.org/ducky/devices.hg#Storer"
11 )
13 var (
14 // ErrNoStorerSet is returned when the Context has no Storer set in it.
15 ErrNoStorerSet = errors.New("storerKey not set in Context")
16 // ErrStorerKeyNotStorer is returned when there's a value in the Context for storerKey, but it's not a Storer.
17 ErrStorerKeyNotStorer = errors.New("the value for storerKey does not fulfill the Storer interface")
18 )
20 func getStorer(c context.Context) (Storer, error) {
21 val := c.Value(storerKey)
22 if val == nil {
23 return nil, ErrNoStorerSet
24 }
25 storer, ok := val.(Storer)
26 if !ok {
27 return nil, ErrStorerKeyNotStorer
28 }
29 return storer, nil
30 }