ducky/devices
ducky/devices/storer_test.go
Set up DeleteDevices in Memstore. Implement the DeleteDevices method for our Memstore, removing the Devices specified by the passed IDs. Also, create a simple test that verifies that when Devices are deleted, only the Devices you intend to delete are actually deleted. Further tests should be written to verify that this extends to ListDevicesByOwner (e.g., deleted devices will not be returned when listing them), CreateDevices (e.g., will not result in an ErrDeviceAlreadyExists error), and UpdateDevice (e.g., will return an ErrDeviceNotFound error after the Device is deleted). But for now, we're confident that it works in the simplest possible case.
1.1 --- a/storer_test.go Sun Nov 29 19:46:20 2015 -0800 1.2 +++ b/storer_test.go Sun Nov 29 21:31:47 2015 -0800 1.3 @@ -359,3 +359,60 @@ 1.4 } 1.5 } 1.6 } 1.7 + 1.8 +func TestDeleteDevicesHappyPath(t *testing.T) { 1.9 + for _, factory := range storerFactories { 1.10 + ctx := context.Background() 1.11 + storer, err := factory.NewStorer(ctx) 1.12 + if err != nil { 1.13 + t.Fatalf("Fatal error creating Storer from %T: %+v\n", factory, err) 1.14 + } 1.15 + 1.16 + owner1, owner2 := uuid.NewID(), uuid.NewID() 1.17 + 1.18 + devices := []Device{ 1.19 + {ID: uuid.NewID(), Name: "Test 1", Owner: owner1, Type: TypeAndroidPhone, Created: time.Now(), LastSeen: time.Now(), PushToken: "test token"}, 1.20 + {ID: uuid.NewID(), Name: "Test 2", Owner: owner2, Type: TypeAndroidTablet, Created: time.Now(), LastSeen: time.Now(), PushToken: "test token"}, 1.21 + {ID: uuid.NewID(), Name: "Test 3", Owner: owner1, Type: TypeChromeExtension, Created: time.Now(), LastSeen: time.Now(), PushToken: "test token"}, 1.22 + } 1.23 + 1.24 + err = storer.CreateDevices(devices, ctx) 1.25 + if err != nil { 1.26 + t.Errorf("Error creating devices in %T: %+v\n", storer, err) 1.27 + } 1.28 + 1.29 + err = storer.DeleteDevices([]uuid.ID{devices[0].ID, devices[1].ID}, ctx) 1.30 + if err != nil { 1.31 + t.Errorf("Error deleting devices from %T: %+v\n", storer, err) 1.32 + } 1.33 + 1.34 + results, err := storer.GetDevices([]uuid.ID{devices[0].ID, devices[1].ID, devices[2].ID}, ctx) 1.35 + if err != nil { 1.36 + t.Errorf("Unexpected error retrieving devices from %T: %+v\n", storer, err) 1.37 + } 1.38 + 1.39 + if len(results) != 1 { 1.40 + t.Errorf("Expected %d results, got %d from %T\n", 1, len(results), storer) 1.41 + } 1.42 + 1.43 + device, ok := results[devices[0].ID.String()] 1.44 + if ok { 1.45 + t.Errorf("Retrieved first device (which was deleted!) from %T: %+v\n", storer, device) 1.46 + } 1.47 + 1.48 + device, ok = results[devices[1].ID.String()] 1.49 + if ok { 1.50 + t.Errorf("Retrieved second device (which was deleted!) from %T: %+v\n", storer, device) 1.51 + } 1.52 + 1.53 + device, ok = results[devices[2].ID.String()] 1.54 + if !ok { 1.55 + t.Errorf("Didn't retrieve third device (which wasn't deleted!) from %T. Got %+v\n", storer, results) 1.56 + } 1.57 + 1.58 + err = factory.TeardownStorer(storer, ctx) 1.59 + if err != nil { 1.60 + t.Errorf("Error cleaning up after %T: %+v\n", storer, err) 1.61 + } 1.62 + } 1.63 +}