auth

Paddy 2014-11-18 Parent:e45bfa2abc00

77:d43c3fbf00f3 Go to Latest

auth/grant_test.go

Write Session tests. Add loginURI as a property to our Context, to keep track of where users should be redirected to log in. Implement the sessionStore in the memstore to let us test with Sessions. Catch when the HTTP Basic Auth header doesn't include two parts, rather than panicking. Return an ErrInvalidAuthFormat. Clean up the error handling for checkCookie to be cleaner. Log unexpected errors from request.Cookie. Stop checking for cookie expiration times--those aren't sent to the server, so we'll never get a valid session if we look for them. Add a helper to build a login redirect URI--a URI the user can be redirected to that has a URL-encoded URL to redirect the user back to after a successful login. Add a wrapper to wrap our Context into HTTP handlers. Create a RegisterOAuth2 helper that adds the OAuth2 endpoints to a Gorilla/mux router. Redirect users to the login page when they have no session set or an invalid session. Return a server error when we can't check our cookie for whatever reason. Log errors. Add sessions to our OAuth2 tests so the tests stop failing--the session check was interfering with them. Add a test for our getBasicAuth helper to ensure that we're parsing basic auth correctly. Add an ErrSessionAlreadyExists error to be returned when a session has an ID conflict. Test that our memstore implementation of the sessionStore works as intended..

History
1 package auth
3 import (
4 "testing"
5 "time"
7 "code.secondbit.org/uuid"
8 )
10 var grantStores = []grantStore{NewMemstore()}
12 func compareGrants(grant1, grant2 Grant) (success bool, field string, grant1val, grant2val interface{}) {
13 if grant1.Code != grant2.Code {
14 return false, "code", grant1.Code, grant2.Code
15 }
16 if !grant1.Created.Equal(grant2.Created) {
17 return false, "created", grant1.Created, grant2.Created
18 }
19 if grant1.ExpiresIn != grant2.ExpiresIn {
20 return false, "expires in", grant1.ExpiresIn, grant2.ExpiresIn
21 }
22 if !grant1.ClientID.Equal(grant2.ClientID) {
23 return false, "client ID", grant1.ClientID, grant2.ClientID
24 }
25 if grant1.Scope != grant2.Scope {
26 return false, "scope", grant1.Scope, grant2.Scope
27 }
28 if grant1.RedirectURI != grant2.RedirectURI {
29 return false, "redirect URI", grant1.RedirectURI, grant2.RedirectURI
30 }
31 if grant1.State != grant2.State {
32 return false, "state", grant1.State, grant2.State
33 }
34 return true, "", nil, nil
35 }
37 func TestGrantStoreSuccess(t *testing.T) {
38 t.Parallel()
39 grant := Grant{
40 Code: "code",
41 Created: time.Now(),
42 ExpiresIn: 180,
43 ClientID: uuid.NewID(),
44 Scope: "scope",
45 RedirectURI: "redirectURI",
46 State: "state",
47 }
48 for _, store := range grantStores {
49 err := store.saveGrant(grant)
50 if err != nil {
51 t.Errorf("Error saving grant to %T: %s", store, err)
52 }
53 err = store.saveGrant(grant)
54 if err != ErrGrantAlreadyExists {
55 t.Errorf("Expected ErrGrantAlreadyExists from %T, got %+v", store, err)
56 }
57 retrieved, err := store.getGrant(grant.Code)
58 if err != nil {
59 t.Errorf("Error retrieving grant from %T: %s", store, err)
60 }
61 match, field, expectation, result := compareGrants(grant, retrieved)
62 if !match {
63 t.Errorf("Expected `%v` in the `%s` field of grant retrieved from %T, got `%v`", expectation, field, store, result)
64 }
65 err = store.deleteGrant(grant.Code)
66 if err != nil {
67 t.Errorf("Error removing grant from %T: %s", store, err)
68 }
69 retrieved, err = store.getGrant(grant.Code)
70 if err != ErrGrantNotFound {
71 t.Errorf("Expected ErrGrantNotFound from %T, got %+v and %+v", store, retrieved, err)
72 }
73 err = store.deleteGrant(grant.Code)
74 if err != ErrGrantNotFound {
75 t.Errorf("Expected ErrGrantNotFound from %T, got %+v", store, err)
76 }
77 }
78 }