auth

Paddy 2014-11-18 Parent:42bc3e44f4fe Child:4cb65cf90217

77:d43c3fbf00f3 Go to Latest

auth/grant.go

Write Session tests. Add loginURI as a property to our Context, to keep track of where users should be redirected to log in. Implement the sessionStore in the memstore to let us test with Sessions. Catch when the HTTP Basic Auth header doesn't include two parts, rather than panicking. Return an ErrInvalidAuthFormat. Clean up the error handling for checkCookie to be cleaner. Log unexpected errors from request.Cookie. Stop checking for cookie expiration times--those aren't sent to the server, so we'll never get a valid session if we look for them. Add a helper to build a login redirect URI--a URI the user can be redirected to that has a URL-encoded URL to redirect the user back to after a successful login. Add a wrapper to wrap our Context into HTTP handlers. Create a RegisterOAuth2 helper that adds the OAuth2 endpoints to a Gorilla/mux router. Redirect users to the login page when they have no session set or an invalid session. Return a server error when we can't check our cookie for whatever reason. Log errors. Add sessions to our OAuth2 tests so the tests stop failing--the session check was interfering with them. Add a test for our getBasicAuth helper to ensure that we're parsing basic auth correctly. Add an ErrSessionAlreadyExists error to be returned when a session has an ID conflict. Test that our memstore implementation of the sessionStore works as intended..

History
1 package auth
3 import (
4 "errors"
5 "time"
7 "code.secondbit.org/uuid"
8 )
10 var (
11 // ErrNoGrantStore is returned when a Context tries to act on a grantStore without setting one first.
12 ErrNoGrantStore = errors.New("no grantStore was specified for the Context")
13 // ErrGrantNotFound is returned when a Grant is requested but not found in the grantStore.
14 ErrGrantNotFound = errors.New("grant not found in grantStore")
15 // ErrGrantAlreadyExists is returned when a Grant is added to a grantStore, but another Grant with the
16 // same Code already exists in the grantStore.
17 ErrGrantAlreadyExists = errors.New("grant already exists in grantStore")
18 )
20 // Grant represents an authorization grant made by a user to a Client, to
21 // access user data within a defined Scope for a limited amount of time.
22 type Grant struct {
23 Code string
24 Created time.Time
25 ExpiresIn int32
26 ClientID uuid.ID
27 Scope string
28 RedirectURI string
29 State string
30 ProfileID uuid.ID
31 }
33 type grantStore interface {
34 getGrant(code string) (Grant, error)
35 saveGrant(grant Grant) error
36 deleteGrant(code string) error
37 }
39 func (m *memstore) getGrant(code string) (Grant, error) {
40 m.grantLock.RLock()
41 defer m.grantLock.RUnlock()
42 grant, ok := m.grants[code]
43 if !ok {
44 return Grant{}, ErrGrantNotFound
45 }
46 return grant, nil
47 }
49 func (m *memstore) saveGrant(grant Grant) error {
50 m.grantLock.Lock()
51 defer m.grantLock.Unlock()
52 _, ok := m.grants[grant.Code]
53 if ok {
54 return ErrGrantAlreadyExists
55 }
56 m.grants[grant.Code] = grant
57 return nil
58 }
60 func (m *memstore) deleteGrant(code string) error {
61 m.grantLock.Lock()
62 defer m.grantLock.Unlock()
63 _, ok := m.grants[code]
64 if !ok {
65 return ErrGrantNotFound
66 }
67 delete(m.grants, code)
68 return nil
69 }