Implement postgres clientStore.
Stop requiring the client ID be passed to clientStore.addEndpoints and
context.AddEndpoints. The Endpoints themselves contain the client ID.
When using the authd server, set the log flags to include the file path and line
number.
Add an ErrEndpointAlreadyExists error, to return when creating an endpoint and
its ID already exists in the database.
Add a Deleted property to Clients and remove the clientStore.deleteClient and
context.DeleteClient methods. We're not going to actually remove that data, and
we want to be able to restore it, so include it in the ClientChange type and
call it using UpdateClient.
Create a ClientChange.Empty helper method that will return whether the
ClientChange has any changes to perform.
Return ErrClientNotFound from clientStore.getClient if the Client's Deleted
property is set to true. This also requires us to ignore ErrClientNotFound
errors when calling memstore.listClientsByOwner, as they should just be skipped
instead of returning an error.
Add the postgres type methods needed to implement clientStore.
Include postgres as a clientStore if the testing.Short() flag is not set.
Generate a new ID for the Client on every run in the tests, now that we can't
actually remove it from the database/memstore in code. We really just need a
*Store.Reset() function that erases all the data and starts over again, to give
the tests a clean execution environment (and so they can clean up after
themselves).
Add the CREATE TABLE statements for the Clients table and the Endpoints table to
sql/postgres_init.sql.
7 "code.secondbit.org/uuid.hg"
10 var sessionStores = []sessionStore{NewMemstore()}
12 func compareSessions(session1, session2 Session) (success bool, field string, val1, val2 interface{}) {
13 if session1.ID != session2.ID {
14 return false, "ID", session1.ID, session2.ID
16 if session1.IP != session2.IP {
17 return false, "IP", session1.IP, session2.IP
19 if session1.UserAgent != session2.UserAgent {
20 return false, "UserAgent", session1.UserAgent, session2.UserAgent
22 if !session1.ProfileID.Equal(session2.ProfileID) {
23 return false, "ProfileID", session1.ProfileID, session2.ProfileID
25 if !session1.Created.Equal(session2.Created) {
26 return false, "Created", session1.Created, session2.Created
28 if !session1.Expires.Equal(session2.Expires) {
29 return false, "Expires", session1.Expires, session2.Expires
31 if session1.Login != session2.Login {
32 return false, "Login", session1.Login, session2.Login
34 if session1.Active != session2.Active {
35 return false, "Active", session1.Active, session2.Active
37 if session1.CSRFToken != session2.CSRFToken {
38 return false, "CSRFToken", session1.CSRFToken, session2.CSRFToken
40 return true, "", nil, nil
43 func TestSessionStoreSuccess(t *testing.T) {
46 ID: uuid.NewID().String() + uuid.NewID().String(),
48 UserAgent: "TestRunner",
49 ProfileID: uuid.NewID(),
50 Created: time.Now().Round(time.Millisecond),
51 Login: "test@example.com",
54 for _, store := range sessionStores {
55 context := Context{sessions: store}
56 err := context.CreateSession(session)
58 t.Errorf("Error saving session to %T: %s", store, err)
60 err = context.CreateSession(session)
61 if err != ErrSessionAlreadyExists {
62 t.Errorf("Expected ErrSessionAlreadyExists from %T, got %s", store, err)
64 retrieved, err := context.GetSession(session.ID)
66 t.Errorf("Error retrieving session from %T: %s", store, err)
68 success, field, expectation, result := compareSessions(session, retrieved)
70 t.Errorf("Expected field %s to be %v, but got %v from %T", field, expectation, result, store)
72 retrievedList, err := context.ListSessions(session.ProfileID, time.Time{}, 10)
74 t.Errorf("Error retrieving sessions by profile from %T: %s", store, err)
76 if len(retrievedList) != 1 {
77 t.Errorf("Expected 1 session retrieved by profile from %T, got %d", store, len(retrievedList))
79 success, field, expectation, result = compareSessions(session, retrievedList[0])
81 t.Errorf("Expected field %s to be %v, but got %v from %T", field, expectation, result, store)
83 err = context.RemoveSession(session.ID)
85 t.Errorf("Error removing session from %T: %s", store, err)
87 retrieved, err = context.GetSession(session.ID)
88 if err != ErrSessionNotFound {
89 t.Errorf("Expected ErrSessionNotFound from %T, got %s", store, err)
91 retrievedList, err = context.ListSessions(session.ProfileID, time.Time{}, 10)
93 t.Errorf("Error retrieving sessions by profile from %T: %s", store, err)
95 if len(retrievedList) != 0 {
96 t.Errorf("Expected 0 sessions retrieved by profile from %T, got %d", store, len(retrievedList))
98 err = context.RemoveSession(session.ID)
99 if err != ErrSessionNotFound {
100 t.Errorf("Expected ErrSessionNotFound from %T, got %s", store, err)
105 // BUG(paddy): We need to test the CreateSessionHandler.
106 // BUG(paddy): We need to test the credentialsValidate function.