Update to use a generic event emitter.
Rather can creating a purpose-built event emitter for each and every event we
need to emit (I'm looking at you, login verification event) which is _downright
silly_, we're now using a generic event publisher that's based on saying "HEY A
MODEL UPDATED".
This means we need to change all our setup code in authd to use
events.NewNSQPublisher or events.NewStdoutPublisher instead of our homegrown
solutions. Which also means updating our config to take an events.Publisher
instead of our LoginVerificationNotifier (blergh).
Our Context also now uses an events.Publisher instead of a
LoginVerificationNotifier. Party all around! We also replaced our
SendLoginVerification helper method on Context with a SendModelEvent helper
method on Context, which is just a light wrapper around
events.PublishModelEvent.
Of course, all this means we need to update our email_verification listener to
listen to the correct channel (based on the model we want updates about) and
filter down to a Created action or our new custom action for "the customer wants
their verification resent", which I'm OK making a special case and not generic,
because c'mon. But we had a subtle change to all our constants, some of which
are unofficial constants now. I'm unsure how I feel about this.
We also updated our email_verification listener so that we're unmarshalling to a
custom loginEvent, which is just an events.Event that overwrites the Data
property to be an auth.Login instance. This is to make sure we don't need to
wrangle a map[string]interface{}, which is no fun. I'm also OK with
special-casing like this, because it's 1) a tiny amount of code, 2) properly
utilising composition, and 3) the only way I can think of to cleanly accomplish
what I want.
I also added a note about GetLogin's deficient handling of logins, namely that
it doesn't recognise admins and return Verification codes to them, which would
be a useful property for internal tools to take advantage of. Ah well.
I updated the Profile and Login implementations so they're now event.Model
instances, mainly by just exporting some strings from them through getters that
will let us automatically build an Event from them. This lets us use the
PublishModelEvent helper.
I updated our CreateProfileHandler to properly mangle the login Verification
property, and to fire off the ActionCreated events for the new Login and the new
Profile.
I updated our GetLoginHandler and UpdateLoginHandler to properly mangle the
loginVerification property. God that's annoying. :-/
You'll note I didn't start publishing the events.ActionUpdated or
events.ActionDeleted events for Profiles or Logins yet, and didn't bother
publishing any events for literally any other type. That's because I'm a lazy
piece of crap and will end up publishing them when I absolutely have to. Part of
that is because if a channel isn't created/being read for a topic, the messages
will just stack up in NSQ, and I don't want that. But mostly I'm lazy.
Finally, I got to delete the entire profile_verification.go file, because we're
no longer special-casing that. Hooray!
4 "code.secondbit.org/uuid.hg"
6 "github.com/secondbit/pan"
9 func (ac AuthorizationCode) GetSQLTableName() string {
10 return "authorization_codes"
13 func (p *postgres) getAuthorizationCodeSQL(code string) *pan.Query {
14 var ac AuthorizationCode
15 fields, _ := pan.GetFields(ac)
16 query := pan.New(pan.POSTGRES, "SELECT "+pan.QueryList(fields)+" FROM "+pan.GetTableName(ac))
18 query.Include(pan.GetUnquotedColumn(ac, "Code")+" = ?", code)
19 return query.FlushExpressions(" ")
22 func (p *postgres) getAuthorizationCode(code string) (AuthorizationCode, error) {
23 query := p.getAuthorizationCodeSQL(code)
24 rows, err := p.db.Query(query.String(), query.Args...)
26 return AuthorizationCode{}, err
28 var ac AuthorizationCode
31 err := pan.Unmarshal(rows, &ac)
37 if err = rows.Err(); err != nil {
41 return ac, ErrAuthorizationCodeNotFound
46 func (p *postgres) saveAuthorizationCodeSQL(authCode AuthorizationCode) *pan.Query {
47 fields, values := pan.GetFields(authCode)
48 query := pan.New(pan.POSTGRES, "INSERT INTO "+pan.GetTableName(authCode))
49 query.Include("(" + pan.QueryList(fields) + ")")
50 query.Include("VALUES")
51 query.Include("("+pan.VariableList(len(values))+")", values...)
52 return query.FlushExpressions(" ")
55 func (p *postgres) saveAuthorizationCode(authCode AuthorizationCode) error {
56 query := p.saveAuthorizationCodeSQL(authCode)
57 _, err := p.db.Exec(query.String(), query.Args...)
58 if e, ok := err.(*pq.Error); ok && e.Constraint == "authorization_codes_pkey" {
59 err = ErrAuthorizationCodeAlreadyExists
64 func (p *postgres) deleteAuthorizationCodeSQL(code string) *pan.Query {
65 var authCode AuthorizationCode
66 query := pan.New(pan.POSTGRES, "DELETE FROM "+pan.GetTableName(authCode))
68 query.Include(pan.GetUnquotedColumn(authCode, "Code")+" = ?", code)
69 return query.FlushExpressions(" ")
72 func (p *postgres) deleteAuthorizationCode(code string) error {
73 query := p.deleteAuthorizationCodeSQL(code)
74 res, err := p.db.Exec(query.String(), query.Args...)
78 rows, err := res.RowsAffected()
83 return ErrAuthorizationCodeNotFound
88 func (p *postgres) deleteAuthorizationCodesByProfileIDSQL(profileID uuid.ID) *pan.Query {
89 var authCode AuthorizationCode
90 query := pan.New(pan.POSTGRES, "DELETE FROM "+pan.GetTableName(authCode))
92 query.Include(pan.GetUnquotedColumn(authCode, "ProfileID")+" = ?", profileID)
93 return query.FlushExpressions(" ")
96 func (p *postgres) deleteAuthorizationCodesByProfileID(profileID uuid.ID) error {
97 query := p.deleteAuthorizationCodesByProfileIDSQL(profileID)
98 res, err := p.db.Exec(query.String(), query.Args...)
102 rows, err := res.RowsAffected()
107 return ErrProfileNotFound
112 func (p *postgres) deleteAuthorizationCodesByClientIDSQL(clientID uuid.ID) *pan.Query {
113 var authCode AuthorizationCode
114 query := pan.New(pan.POSTGRES, "DELETE FROM "+pan.GetTableName(authCode))
116 query.Include(pan.GetUnquotedColumn(authCode, "ClientID")+" = ?", clientID)
117 return query.FlushExpressions(" ")
120 func (p *postgres) deleteAuthorizationCodesByClientID(clientID uuid.ID) error {
121 query := p.deleteAuthorizationCodesByClientIDSQL(clientID)
122 res, err := p.db.Exec(query.String(), query.Args...)
126 rows, err := res.RowsAffected()
131 return ErrClientNotFound
136 func (p *postgres) useAuthorizationCodeSQL(code string) *pan.Query {
137 var authCode AuthorizationCode
138 query := pan.New(pan.POSTGRES, "UPDATE "+pan.GetTableName(authCode)+" SET ")
139 query.Include(pan.GetUnquotedColumn(authCode, "Used")+" = ?", true)
141 query.Include(pan.GetUnquotedColumn(authCode, "Code")+" = ?", code)
142 return query.FlushExpressions(" ")
145 func (p *postgres) useAuthorizationCode(code string) error {
146 query := p.useAuthorizationCodeSQL(code)
147 res, err := p.db.Exec(query.String(), query.Args...)
151 rows, err := res.RowsAffected()
156 return ErrAuthorizationCodeNotFound