auth

Paddy 2015-01-19 Parent:d14f0a81498c Child:163ce22fa4c9

128:23c1a07c8a61 Go to Latest

auth/session.go

Add our BUG notices. Rather than keeping the list of things to implement or test on sticky notes attached to my monitor, let's give them BUG designations within the code. Now `godoc . bugs` will list them out for us. Isn't that nice?

Download raw file
View source Diff to previous Annotate
History 
     1.1 --- a/session.go	Mon Jan 19 06:01:51 2015 -0500
     1.2 +++ b/session.go	Mon Jan 19 06:42:42 2015 -0500
     1.3 @@ -141,6 +141,8 @@
     1.4  // RegisterSessionHandlers adds handlers to the passed router to handle the session endpoints, like login and logout.
     1.5  func RegisterSessionHandlers(r *mux.Router, context Context) {
     1.6  	r.Handle("/login", wrap(context, CreateSessionHandler))
     1.7 +	// BUG(paddy): We need to implement a handler for listing sessions active on a profile.
     1.8 +	// BUG(paddy): We need to implement a handler for terminating sessions.
     1.9  }
    1.10  
    1.11  func checkCookie(r *http.Request, context Context) (Session, error) {
    1.12 @@ -255,7 +257,7 @@
    1.13  				w.Write([]byte(err.Error()))
    1.14  				return
    1.15  			}
    1.16 -			// BUG(paddy): really need to do a security audit on our cookie
    1.17 +			// BUG(paddy): We really need to do a security audit on our cookie.
    1.18  			cookie := http.Cookie{
    1.19  				Name:     authCookieName,
    1.20  				Value:    session.ID,