auth
auth/authd/templates/simple.gotmpl
Refactor verifyClient, implement refresh tokens. Refactor verifyClient into verifyClient and getClientAuth. We moved verifyClient out of each of the GrantType's validation functions and into the access token endpoint, where it will be called before the GrantType's validation function. Yay, less code repetition. And seeing as we always want to verify the client, that seems like a good way to prevent things like 118a69954621 from happening. This did, however, force us to add an AllowsPublic property to the GrantType, so the token endpoint knows whether or not a public Client is valid for any given GrantType. We also implemented the refresh token grant type, which required adding ClientID and RefreshRevoked as properties on the Token type. We need ClientID because we need to constrain refresh tokens to the client that issued them. We also should probably keep track of which tokens belong to which clients, just as a general rule of thumb. RefreshRevoked had to be created, next to Revoked, because the AccessToken could be revoked and the RefreshToken still valid, or vice versa. Notably, when you issue a new refresh token, the old one is revoked, but the access token is still valid. It remains to be seen whether this is a good way to track things or not. The number of duplicated properties lead me to believe our type is not a great representation of the underlying concepts.
| paddy@100 | 1 {{ define "login" }}<html> |
| paddy@100 | 2 <head> |
| paddy@100 | 3 <title>Log in</title> |
| paddy@100 | 4 </head> |
| paddy@100 | 5 <body> |
| paddy@100 | 6 <h1>Please log into your account</h1>{{ if .errors }} |
| paddy@100 | 7 <h2>Errors:</h2> |
| paddy@100 | 8 <ul>{{ range .errors }} |
| paddy@100 | 9 <li>{{ . }}</li> |
| paddy@100 | 10 </ul>{{ end }}{{ end }} |
| paddy@100 | 11 <form method="POST"> |
| paddy@100 | 12 <p>Username: <input type="text" name="login"></p> |
| paddy@100 | 13 <p>Password: <input type="password" name="passphrase"></p> |
| paddy@100 | 14 <p><input type="submit"></p> |
| paddy@100 | 15 </form> |
| paddy@100 | 16 </body> |
| paddy@100 | 17 </html>{{ end }} |
| paddy@106 | 18 |
| paddy@106 | 19 {{ define "get_grant" }}<html> |
| paddy@106 | 20 <head> |
| paddy@106 | 21 <title>Grant access</title> |
| paddy@106 | 22 </head> |
| paddy@106 | 23 <body>{{ if .error }} |
| paddy@106 | 24 <h1>Error</h1> |
| paddy@106 | 25 <p>{{ .error }}</p>{{ end }}{{ if .internal_error }} |
| paddy@106 | 26 <h1>Error</h1> |
| paddy@106 | 27 <p>{{ .internal_error }}</p>{{ end }}{{ if not .error }}{{ if not .internal_error }}<h1>Grant access</h1> |
| paddy@108 | 28 <p>{{ .client.Name }} is requesting access to your account. if you grant it, you'll be redirected to {{ .redirectURL }}. Their access will be limited to {{ .scope }}. You are granting access for {{ .profile.Name }}.</p>{{ end }}{{ end }} |
| paddy@108 | 29 <form method="POST"> |
| paddy@108 | 30 <input type="submit" name="grant" value="approved"> |
| paddy@108 | 31 </form> |
| paddy@106 | 32 </body> |
| paddy@106 | 33 </html>{{ end }} |