http://code.secondbit.org/ducky/subscriptions/ en-us ducky/subscriptions Changelog http://code.secondbit.org/ducky/subscriptions/rev/7eef47ecc01c http://code.secondbit.org/ducky/subscriptions/rev/7eef47ecc01c changeset 7eef47ecc01c branch default bookmark tag tip user Paddy <paddy@secondbit.org> description Document our client to make golint happy.

Take care of all the documentation warnings in the client subpackage, which
means golint now returns successfully. files client/client.go
client/subscription.go
]]> Paddy <paddy@secondbit.org> Sun, 04 Oct 2015 22:27:54 -0700 http://code.secondbit.org/ducky/subscriptions/rev/b063bc0a6e84 http://code.secondbit.org/ducky/subscriptions/rev/b063bc0a6e84 changeset b063bc0a6e84 branch bookmark tag user Paddy <paddy@secondbit.org> description Make api subpackage golint-passing.

Add comments to all the exported functions, methods, and variables in the api
subpackage, to make golint happy.

Also, make the individual endpoints in the api subpackage unexported, as there's
no real use case for exporting them. The handlers depend on the placeholders in
the endpoint, so we need them to be controlled in unison, which means it's
probably a bad idea to declare the route outside of the API package. And the
only reason to expose the Handler is so people can declare custom endpoints. files api/context_helpers.go
api/response.go
api/subscription_handlers.go
]]> Paddy <paddy@secondbit.org> Sun, 04 Oct 2015 21:58:07 -0700 http://code.secondbit.org/ducky/subscriptions/rev/aab6ba5ae392 http://code.secondbit.org/ducky/subscriptions/rev/aab6ba5ae392 changeset aab6ba5ae392 branch bookmark tag user Paddy <paddy@secondbit.org> description Log Postgres test failures more verbosely, fix SubscriptionChange.IsEmpty.

SubscriptionChange.IsEmpty() would return false even if no actual database
operations are going to be performed. This is because we allow information we
_don't_ store in the database (Stripe source, Stripe email) to be specified in a
SubscriptionChange object, just so we can easily access them. Then we use the
Stripe API to store them in Stripe's databases, and turn them into data _we_
store in our database. Think of them as pre-processed values that are never
stored raw.

The problem is, we were treating these properties the same as the properties we
actually stored in the database, and (worse) were running database tests for
combinations of these properties, which was causing test failures because we
were trying to update no columns in the database. Whoops.

I removed these properties from the IsEmpty helper, and removed them from the
code that generates the SubscriptionChange permutations for testing. This allows
tests to pass, but also stays closer to what the system was designed to do.

In tracking down this bug, I discovered that the logging we had for errors when
running Postgres tests was inadequate, so I updated the logs when that failure
occurs while testing Postgres to help surface future failures faster. files subscription.go
subscription_store_test.go
]]> Paddy <paddy@secondbit.org> Wed, 30 Sep 2015 01:33:53 -0700 http://code.secondbit.org/ducky/subscriptions/rev/fb2c0e498e37 http://code.secondbit.org/ducky/subscriptions/rev/fb2c0e498e37 changeset fb2c0e498e37 branch bookmark tag user Paddy <paddy@secondbit.org> description Update with comments for all exported functions.

We now have golint-approved comments for all the exported functions in the
subscriptions package.

Next challenge: all the sub-packages! files subscription_memstore.go
subscription_postgres.go
]]> Paddy <paddy@secondbit.org> Wed, 30 Sep 2015 01:03:39 -0700 http://code.secondbit.org/ducky/subscriptions/rev/1ff031bebf9e http://code.secondbit.org/ducky/subscriptions/rev/1ff031bebf9e changeset 1ff031bebf9e branch bookmark tag user Paddy <paddy@secondbit.org> description Add golint comments.

Comment on some more of our exported types, functions, and variables, both to
make golint happy and because uncommented code never ever ends well. files memstore.go
stripe.go
]]> Paddy <paddy@secondbit.org> Sun, 27 Sep 2015 21:20:46 -0700 http://code.secondbit.org/ducky/subscriptions/rev/39625b37485d http://code.secondbit.org/ducky/subscriptions/rev/39625b37485d changeset 39625b37485d branch bookmark tag user Paddy <paddy@secondbit.org> description Fix go vet errors.

We had a few logging statements that used placeholders but didn't provide any
variables to fill them. We now specify the appropriate variables. files listeners/subscription_creator/subscription_creator.go
]]> Paddy <paddy@secondbit.org> Sun, 27 Sep 2015 21:20:09 -0700 http://code.secondbit.org/ducky/subscriptions/rev/0ae1ff0ee306 http://code.secondbit.org/ducky/subscriptions/rev/0ae1ff0ee306 changeset 0ae1ff0ee306 branch bookmark tag user Paddy <paddy@secondbit.org> description Add comments, move ChangingSystemProperties to the api package.

Add comments to all our exported types and variables in subscription.go, both to
make golint happy and because it's good to have comments.

Move the subscriptions.ChangingSystemProperties helper to
api.changingSystemProperties, because it returns API-specific strings and
there's no real reason it has to be in the subscriptions package--everything it
needs to work on is exported. files api/subscription_handlers.go
subscription.go
]]> Paddy <paddy@secondbit.org> Sun, 27 Sep 2015 21:18:45 -0700 http://code.secondbit.org/ducky/subscriptions/rev/2c8250237566 http://code.secondbit.org/ducky/subscriptions/rev/2c8250237566 changeset 2c8250237566 branch bookmark tag user Paddy <paddy@secondbit.org> description Update subscription_creator to use the new strategy.

When creating subscriptions through the client, detect when the returned error
is saying the account already has a subscription, or the subscription already
exists in stripe.

Add an UpdateSubscription function that will update a subscription through the
API.

Update our subscription_creator listener to listen for profile creation and
login verification messages. This mainly involved fixing the constants (the
system, model, and topic) that the listener for profile creation was listening
for. It also meant adding a new updateMessageHandler that listens for login
verification, tries to create a subscription that has the user ID and email of
the login that was verified, and if a subscription already exists, updates it
instead to use the email address that was just verified. This will ensure that
users get their receipts automatically emailed to them by Stripe. files client/subscription.go
listeners/subscription_creator/subscription_creator.go
]]> Paddy <paddy@secondbit.org> Sat, 18 Jul 2015 03:28:51 -0400 http://code.secondbit.org/ducky/subscriptions/rev/8eb19bcbf17d http://code.secondbit.org/ducky/subscriptions/rev/8eb19bcbf17d changeset 8eb19bcbf17d branch bookmark tag user Paddy <paddy@secondbit.org> description Return errors from responses in client.

When the client makes a request, non-200 responses _are not_ considered errors.
So we need to check the response.Errors property, and if it has errors, _then_
we consider the request to have an error. To make this happen, we created an
httpErrors type that fulfills the error interface and just wraps the response
Errors property. Then callers can type-cast it and interrogate it. files client/client.go
]]> Paddy <paddy@secondbit.org> Sat, 18 Jul 2015 03:26:56 -0400 http://code.secondbit.org/ducky/subscriptions/rev/61583c1d3886 http://code.secondbit.org/ducky/subscriptions/rev/61583c1d3886 changeset 61583c1d3886 branch bookmark tag user Paddy <paddy@secondbit.org> description Create a listener that will create subscriptions.

We need a listener (as discussed in c4cfceb2f2fb) that will create a
Subscription whenever an auth.Profile is created. This is the beginning of that
effort. It hasn't been tested, and all the pieces aren't in place, but it's a
rough skeleton.

We have a Dockerfile that will correctly build a minimal container for the
listener.

We have a build-docker.sh script that will correctly build a binary that will be
used in the Dockerfile.

We have a ca-certificates.crt, which are pulled from Ubuntu, and are necessary
before we can safely consume SSL endpoints.

We created a small consumer script that listens for events off NSQ, and calls
the appropriate endpoint for our Subscriptions API. This is untested, and it
doesn't build at the moment, but that's awaiting changes in the
code.secondbit.org/auth.hg package.

Finally, we have a wrapper.sh file that will expose the Stripe secret key being
used from a Kubernetes secret file as an environment variable, instead. files listeners/subscription_creator/Dockerfile
listeners/subscription_creator/build-docker.sh
listeners/subscription_creator/ca-certificates.crt
listeners/subscription_creator/subscription_creator.go
listeners/subscription_creator/wrapper.sh
]]> Paddy <paddy@secondbit.org> Mon, 13 Jul 2015 23:38:22 -0400