ducky/devices

Paddy 2015-11-12 Parent:600326d50e74 Child:8d40c0e5f4d9

2:426d7e3c4ecd Browse Files

Start testing our Storers. Set up a file to start testing our Storer implementations, and write a sample test for the happy path of GetDevices--e.g., we expect no errors. This also required us to setup a helper to compare two Device instances and see if they're equal or not, and if not, how they differ. In the future, we'll keep adding test methods to test more logical paths for the interface contract, and to test more of the methods for the interface.

storer_test.go

     1.1 --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
     1.2 +++ b/storer_test.go	Thu Nov 12 22:19:38 2015 -0800
     1.3 @@ -0,0 +1,74 @@
     1.4 +package devices
     1.5 +
     1.6 +import (
     1.7 +	"testing"
     1.8 +	"time"
     1.9 +
    1.10 +	"code.secondbit.org/uuid.hg"
    1.11 +	"golang.org/x/net/context"
    1.12 +)
    1.13 +
    1.14 +var storers []Storer
    1.15 +
    1.16 +func compareDevices(device1, device2 Device) (ok bool, field string, expected, result interface{}) {
    1.17 +	if !device1.ID.Equal(device2.ID) {
    1.18 +		return false, "ID", device1.ID, device2.ID
    1.19 +	}
    1.20 +	if device1.Name != device2.Name {
    1.21 +		return false, "Name", device1.Name, device2.Name
    1.22 +	}
    1.23 +	if !device1.Owner.Equal(device2.Owner) {
    1.24 +		return false, "Owner", device1.Owner, device2.Owner
    1.25 +	}
    1.26 +	if device1.Type != device2.Type {
    1.27 +		return false, "Type", device1.Type, device2.Type
    1.28 +	}
    1.29 +	if !device1.Created.Equal(device2.Created) {
    1.30 +		return false, "Created", device1.Created, device2.Created
    1.31 +	}
    1.32 +	if !device1.LastSeen.Equal(device2.LastSeen) {
    1.33 +		return false, "LastSeen", device1.LastSeen, device2.LastSeen
    1.34 +	}
    1.35 +	if device1.PushToken != device2.PushToken {
    1.36 +		return false, "PushToken", device1.PushToken, device2.PushToken
    1.37 +	}
    1.38 +	return true, "", nil, nil
    1.39 +}
    1.40 +
    1.41 +func TestGetDevicesHappyPath(t *testing.T) {
    1.42 +	for _, storer := range storers {
    1.43 +		storer, err := storer.Factory(context.TODO())
    1.44 +		if err != nil {
    1.45 +			t.Fatalf("Fatal error creating %T: %+v\n", storer, err)
    1.46 +		}
    1.47 +
    1.48 +		devices := []Device{
    1.49 +			{ID: uuid.NewID(), Name: "Test 1", Owner: uuid.NewID(), Type: TypeAndroidPhone, Created: time.Now(), LastSeen: time.Now(), PushToken: "test token"},
    1.50 +			{ID: uuid.NewID(), Name: "Test 2", Owner: uuid.NewID(), Type: TypeAndroidTablet, Created: time.Now(), LastSeen: time.Now(), PushToken: "test token"},
    1.51 +			{ID: uuid.NewID(), Name: "Test 3", Owner: uuid.NewID(), Type: TypeChromeExtension, Created: time.Now(), LastSeen: time.Now(), PushToken: "test token"},
    1.52 +		}
    1.53 +		ids := make([]uuid.ID, 0, len(devices))
    1.54 +		for _, device := range devices {
    1.55 +			ids = append(ids, device.ID)
    1.56 +		}
    1.57 +
    1.58 +		results, err := storer.GetDevices(ids, context.TODO())
    1.59 +		if err != nil {
    1.60 +			t.Errorf("Unexpected error retrieving devices from %T: %+v\n", storer, err)
    1.61 +		}
    1.62 +		for _, device := range devices {
    1.63 +			d, returned := results[device.ID.String()]
    1.64 +			if !returned {
    1.65 +				t.Errorf("Expected device %s to be in results from %T, but wasn't present\n", device.Name, storer)
    1.66 +			}
    1.67 +			ok, field, expected, result := compareDevices(device, d)
    1.68 +			if !ok {
    1.69 +				t.Errorf("Expected %s of %s to be %v, got %v from %T\n", field, device.Name, expected, result, storer)
    1.70 +			}
    1.71 +		}
    1.72 +		err = storer.Destroy(context.TODO())
    1.73 +		if err != nil {
    1.74 +			t.Errorf("Error cleaning up after %T: %+v\n", storer, err)
    1.75 +		}
    1.76 +	}
    1.77 +}